Messages in this thread | | | Date | Tue, 3 Aug 2010 14:35:09 +0900 | Subject | Re: [PATCH 9/9] x86: Detect whether we should use Xen SWIOTLB. | From | FUJITA Tomonori <> |
| |
On Mon, 2 Aug 2010 12:42:34 -0400 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> > But his attempt to create "swiotlb iommu function array" and "hardware > > iommu function array" looks like to makes the code more unreadable. > > Let me go to my favorite coffee shop and think this one through. > Can I get concession for putting the original patch in (the simple, dumb one), > and then: > - start working on the IOMMU register interface without having to try > to get it done for 2.6.36, and > - do the driverization as a seperate cleanup.
We could simplify swiotlb initialization after 2.6.36. If we merge my patches to expand swiotlb memory dynamically, we could initialize swiotlb before any hw IOMMUs (see the commit 186a25026c44d1bfa97671110ff14dcd0c99678e).
If you can make Xen swiotlb initialized like HW iommu, the IOMMU initialization could be cleaner.
As I wrote, I also want to simplify swiotlb's init memory allocation. I'll see what I can do on the whole issue.
| |