Messages in this thread | | | Date | Tue, 03 Aug 2010 07:32:35 -0700 | From | "Justin P. Mattock" <> | Subject | Re: [PATCH]scripts/kconfig/nconf.gui.c Fix warning: value computed is not used |
| |
On 08/03/2010 06:46 AM, Nir Tzachar wrote: > 2010/8/3 Justin P. Mattock<justinmattock@gmail.com>: >> On 08/03/2010 02:59 AM, Michal Marek wrote: >>> >>> On 3.8.2010 01:16, Justin P. Mattock wrote: >>>> >>>> The below patch fixes some warning messages Im getting when doing >>>> make nconfig >>>> >>>> make nconfig >>>> HOSTCC scripts/kconfig/nconf.gui.o >>>> scripts/kconfig/nconf.gui.c: In function 'print_in_middle': >>>> scripts/kconfig/nconf.gui.c:170:2: warning: value computed is not used >>>> scripts/kconfig/nconf.gui.c: In function 'btn_dialog': >>>> scripts/kconfig/nconf.gui.c:300:2: warning: value computed is not used >>>> scripts/kconfig/nconf.gui.c:304:2: warning: value computed is not used >>>> scripts/kconfig/nconf.gui.c: In function 'dialog_inputbox': >>>> scripts/kconfig/nconf.gui.c:395:2: warning: value computed is not used >>>> scripts/kconfig/nconf.gui.c:397:2: warning: value computed is not used >>>> scripts/kconfig/nconf.gui.c:399:2: warning: value computed is not used >>>> scripts/kconfig/nconf.gui.c:404:2: warning: value computed is not used >>>> scripts/kconfig/nconf.gui.c: In function 'show_scroll_win': >>>> scripts/kconfig/nconf.gui.c:534:2: warning: value computed is not used >>>> scripts/kconfig/nconf.gui.c:549:2: warning: value computed is not used >>>> scripts/kconfig/nconf.gui.c:551:2: warning: value computed is not used >>>> HOSTLD scripts/kconfig/nconf >>>> scripts/kconfig/nconf arch/x86/Kconfig >>>> >>>> I looked around for a way to fix these, but am not familiar with ncurses. >>>> if there's a better way let me know and/or send a seperate fix. >>>> >>>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com> >>>> >>>> --- >>>> scripts/kconfig/nconf.gui.c | 11 ----------- >>>> 1 files changed, 0 insertions(+), 11 deletions(-) >>>> >>>> diff --git a/scripts/kconfig/nconf.gui.c b/scripts/kconfig/nconf.gui.c >>>> index a9d9344..08a5a04 100644 >>>> --- a/scripts/kconfig/nconf.gui.c >>>> +++ b/scripts/kconfig/nconf.gui.c >>>> @@ -167,7 +167,6 @@ void print_in_middle(WINDOW *win, >>>> length = strlen(string); >>>> temp = (width - length) / 2; >>>> x = startx + (int)temp; >>>> - wattrset(win, color); >>> >>> Huh? :) This change makes nconfig look black and white. I'm all for >>> eliminating warnings, but please do not eliminate features at the same >>> time (or submit a patch with "Subject: make nconfig black and white" and >>> do not mask it as warning fixes). >>> >>> Michal >>> >> >> hmm.. make nconfig is black and white even without this patch, is that >> normal? > > No. It should be using colors. Which terminal are you using? Also, > make sure you do not have the wide characters version of ncurses > installed.
Im using xterm.. ncurses was built with --enable-widec on both machines which probably explains why the whole black and white look.
> >> as for the patch not real sure how to handle these(ncurses), but at least >> you know now.. as for masking this with warning fixes.. ouch!! that's a >> first... these are what gcc 4.6 are giving me not the other way around my >> friend. > > These warnings are all noise, but should be solved in the last patch I > sent Michal. > > Cheers. >
cool..
Justin P. Mattock
| |