lkml.org 
[lkml]   [2010]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC 10/12] x86/pvticketlock: keep count of blocked cpus
On Tue, Aug 03, 2010 at 10:32:40AM +0200, Peter Zijlstra wrote:
> On Fri, 2010-07-16 at 18:03 -0700, Jeremy Fitzhardinge wrote:
> > @@ -26,6 +26,9 @@ typedef struct arch_spinlock {
> > __ticket_t head, tail;
> > } tickets;
> > };
> > +#ifdef CONFIG_PARAVIRT_SPINLOCKS
> > + __ticket_t waiting;
> > +#endif
> > } arch_spinlock_t;
>
> This bloats spinlock_t from u32 to u64 on most distro configs I think,
> since they'll have NR_CPUS=4096 or something large like that and
> probably also want to have this PARAVIRT_SPINLOCKS thing.

Which sucks for carefully packed data structures like dentry.
They'll tend to grow by 8 bytes per spinlock.


\
 
 \ /
  Last update: 2010-08-03 11:47    [from the cache]
©2003-2011 Jasper Spaans