Messages in this thread | | | Date | Sun, 29 Aug 2010 18:26:02 -0400 | From | Rik van Riel <> | Subject | Re: [PATCH] vmscan: prevent background aging of anon page in no swap system |
| |
On 08/29/2010 05:23 PM, Ying Han wrote: > On Sun, Aug 29, 2010 at 1:03 PM, Rik van Riel<riel@redhat.com> wrote: >> On 08/29/2010 01:45 PM, Ying Han wrote: >> >>> There are few other places in vmscan where we check nr_swap_pages and >>> inactive_anon_is_low. Are we planning to change them to use >>> total_swap_pages >>> to be consistent ? >> >> If that makes sense, maybe the check can just be moved into >> inactive_anon_is_low itself? > > That was the initial patch posted, instead we changed to use > total_swap_pages instead. How this patch looks:
Looks good to me. It could use a comment along the lines of:
/* * No sense scanning the anon lists if we have no swap space. */
... and, of course, your signed-off-by :)
-- All rights reversed
| |