lkml.org 
[lkml]   [2010]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC PATCH 02/43] ptrace: cleanup ptrace_request()
Date
On Friday 27 August 2010 18:13:35 Namhyung Kim wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
> > If you introduce two pointers, 'siginfo_t __user *usiginfo' and
> > 'unsigned long __user *datap' instead of just 'datap', you can use
> > get_user/put_user everywhere, which would make the code better readable
> > and faster.
> >
> > Otherwise this change looks good.
> >
>
> Despite I don't know how much it can run faster, I just want to keep it as is
> unless it would be a serious mistake. :-)

No, not a mistake, your code is fine as it is and not performance
critical at all.

However, in general using get_user/put_user is preferred over
copy_from_user/copy_to_user for scalar values.

Arnd


\
 
 \ /
  Last update: 2010-08-27 21:29    [W:0.058 / U:0.252 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site