lkml.org 
[lkml]   [2010]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC PATCH 14/43] ptrace, frv: change signature of arch_ptrace()
Date
Namhyung Kim <namhyung@gmail.com> wrote:

> > That description means nothing. Commit
> > f76671df26ef06321480e702770f88f61272be29 is not upstream.
>
> Hi,
> Thank you for noticing. My bad.

The problem with using a non-upstream commit ID like this is that it likely
won't be the same once that commit is committed by Linus.

> I just wanted to let you know it depends on that.

The patch being part of the series is probably sufficient, though a note of
the subject line of the previous patch would be useful.

> What is the proper way to handle this?

A summary of the changes being made is good:

ptrace: Fix up the arguments arch_ptrace() in arch FRV

Fix up the arguments to arch_ptrace() to take account of the fact that
addr and data are now unsigned long rather than long as of a preceding
patch in this series.

Signed-off-by: ...

Note, however, that if the earlier patch breaks the compilation and then this
patch fixes it up, you should roll this patch into the earlier patch, and the
earlier patch is not complete without it.

Think what happens if patch 3/43 breaks an arch, and then patch 43/43, say,
mends that arch, and then bisection lands on patch 3 during its progress. You
may end up having to 'git bisect skip' all the patches between 3 and 43 one at
a time.

David


\
 
 \ /
  Last update: 2010-08-27 14:15    [W:0.071 / U:2.600 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site