Messages in this thread | | | Subject | Re: [PATCH] writeback: remove the internal 5% low bound on dirty_ratio | From | Peter Zijlstra <> | Date | Fri, 27 Aug 2010 12:39:39 +0200 |
| |
On Fri, 2010-08-27 at 18:36 +0800, Wu Fengguang wrote: > The dirty_ratio was siliently limited in global_dirty_limits() to >= 5%. > This is not a user expected behavior. And it's inconsistent with > calc_period_shift(), which uses the plain vm_dirty_ratio value. > > Let's rip the internal bound. > > At the same time, fix balance_dirty_pages() to work with the > dirty_thresh=0 case. This allows applications to proceed when > dirty+writeback pages are all cleaned. > > And ">" fits with the name "exceeded" better than ">=" does. Neil > think it is an aesthetic improvement as well as a functional one :) > > CC: Jan Kara <jack@suse.cz> > CC: Rik van Riel <riel@redhat.com> Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl> > Proposed-by: Con Kolivas <kernel@kolivas.org> > Reviewed-by: Neil Brown <neilb@suse.de> > Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
| |