lkml.org 
[lkml]   [2010]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] writeback: remove the internal 5% low bound on dirty_ratio
Date
> > writeback: remove the internal 5% low bound on dirty_ratio
> >
> > The dirty_ratio was silently limited in global_dirty_limits() to >= 5%.
> > This is not a user expected behavior. And it's inconsistent with
> > calc_period_shift(), which uses the plain vm_dirty_ratio value.
> >
> > Let's rip the internal bound.
> >
> > At the same time, fix balance_dirty_pages() to work with the
> > dirty_thresh=0 case. This allows applications to proceed when
> > dirty+writeback pages are all cleaned.
>
> And ">" fits with the name "exceeded" better than ">=" does. I think it is
> an aesthetic improvement as well as a functional one.
>
> Reviewed-by: NeilBrown <neilb@suse.de>

I agree :)
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>






\
 
 \ /
  Last update: 2010-08-26 06:25    [W:0.061 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site