Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH] writeback: remove the internal 5% low bound on dirty_ratio | Date | Thu, 26 Aug 2010 13:22:02 +0900 (JST) |
| |
> > writeback: remove the internal 5% low bound on dirty_ratio > > > > The dirty_ratio was silently limited in global_dirty_limits() to >= 5%. > > This is not a user expected behavior. And it's inconsistent with > > calc_period_shift(), which uses the plain vm_dirty_ratio value. > > > > Let's rip the internal bound. > > > > At the same time, fix balance_dirty_pages() to work with the > > dirty_thresh=0 case. This allows applications to proceed when > > dirty+writeback pages are all cleaned. > > And ">" fits with the name "exceeded" better than ">=" does. I think it is > an aesthetic improvement as well as a functional one. > > Reviewed-by: NeilBrown <neilb@suse.de>
I agree :) Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
| |