Messages in this thread |  | | Date | Fri, 27 Aug 2010 10:03:05 +0900 | Subject | Re: [PATCH] vmscan: fix missing place to check nr_swap_pages. | From | Minchan Kim <> |
| |
Hello.
On Fri, Aug 27, 2010 at 9:11 AM, Ying Han <yinghan@google.com> wrote: > Fix a missed place where checks nr_swap_pages to do shrink_active_list. Make the > change that moves the check to common function inactive_anon_is_low. >
Hmm.. AFAIR, we discussed it at that time but we concluded it's not good. That's because nr_swap_pages < 0 means both "NO SWAP" and "NOT enough swap space now". If we have a swap device or file but not enough space now, we need to aging anon pages to make inactive list enough size. Otherwise, working set pages would be swapped out more fast before promotion.
That aging is done by kswapd so I think it's not big harmful in the system. But if you want to remove aging completely in non-swap system, we need to identify non swap system and not enough swap space. I thought we need it for embedded system.
Thanks.
-- Kind regards, Minchan Kim
|  |