Messages in this thread | | | Subject | Re: [RFC patch (against wireless-next)] include/net/cfg80211.h: wiphy_<level> messages use dev_printk | From | Johannes Berg <> | Date | Wed, 25 Aug 2010 20:25:36 +0200 |
| |
On Wed, 2010-08-25 at 14:01 -0400, John W. Linville wrote:
> > "<level>dev_driver_string(&wiphy->dev) dev_name(&wiphy->dev): wiphy_name(wiphy): " fmt, ##args > > > > for instance: > > > > [ 41.261941] ieee80211 phy0: phy0: Selected rate control algorithm 'minstrel_ht' > > > > ie: redundant. > > wiphy_name(wiphy) is an inline for dev_name(&wiphy->dev) > > > > So it's appropriate to use: > > > > #define wiphy_<level>(wiphy, fmt, arg...) dev_<level>(&wiphy->dev, fmt, ##arg) > > > > and the output becomes: > > > > [ 41.261941] ieee80211 phy0: Selected rate control algorithm 'minstrel_ht' > > > > Signed-off-by: Joe Perches <joe@perches.com> > > Everyone OK w/ this version?
I don't care much :)
johannes
| |