Messages in this thread | | | Date | Wed, 25 Aug 2010 18:12:14 +0200 | From | Andreas Mohr <> | Subject | Re: [PATCH] x86: EuroBraille/Iris power off |
| |
Hi,
excellent! Now if as the next step before inclusion you also add the usual DMI check (as done by many drivers such as acerhdf etc.), someone inexperienced who is dumb enough to enable it for his unrelated machine will actually survive an otherwise raw I/O port access and poweroff vector change ;))
Unless these non-APM, non-ACPI machines don't have any DMI support either and thus won't even have dmidecode work..... (in which case I'd strongly suggest adding a 0x340+x port value read verification to bail driver install in case the machine doesn't have this hardware).
Andreas Mohr
| |