Messages in this thread | | | From | Linus Torvalds <> | Date | Tue, 24 Aug 2010 09:53:12 -0700 | Subject | Re: [PATCH] guard page for stacks that grow upwards |
| |
On Tue, Aug 24, 2010 at 9:31 AM, Luck, Tony <tony.luck@intel.com> wrote: > > Updated to match the new code - still not tested on pa-risc.
But the ia64 grows-up case is tested?
> The #ifdefs are ugly - suggestions welcome on how to make > the code prettier.
One thing I've considered is to get rid of the CONFIG_STACK_GROWSUP crap entirely in code, and instead just make the VM_GROWSUP #define be 0 for architectures that don't want it. The compiler should then just automatically remove all the code that says
if (vma->vm_flags & VM_GROWSUP) { ...
and the code would look more straightforward. Hmm?
Linus
| |