Messages in this thread | | | Date | Mon, 23 Aug 2010 19:19:42 +0300 | From | Avi Kivity <> | Subject | Re: [PATCH v5 03/12] Add async PF initialization to PV guest. |
| |
On 08/23/2010 07:08 PM, Christoph Lameter wrote: > On Mon, 23 Aug 2010, Gleb Natapov wrote: > >>> The guest will have to align this on a 64 byte boundary, should this >>> be marked __aligned(64) here? >>> >> I do __aligned(64) when I declare variable of that type: >> >> static DEFINE_PER_CPU(struct kvm_vcpu_pv_apf_data, apf_reason) __aligned(64); > 64 byte boundary: You mean cacheline aligned? We have a special define for > that. > > DEFINE_PER_CPU_SHARED_ALIGNED >
It's an ABI, so we can't use something that might change when Intel releases a cpu with 75.2 byte cache lines.
-- error compiling committee.c: too many arguments to function
| |