Messages in this thread | | | Date | Mon, 23 Aug 2010 11:02:48 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 2/2] regulator: tps6586x-regulator - fix bit_mask parameter for tps6586x_set_bits() |
| |
On Sun, Aug 22, 2010 at 10:42:42PM +0800, Axel Lin wrote: > The third parameter of tps6586x_set_bits() is the bit_mask, > thus we should use (1 << ri->go_bit) instead of ri->go_bit. > > Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
but I'd be much happier if someone who actually has the hardware could verify that this is OK.
| |