Messages in this thread | | | From | Linus Torvalds <> | Date | Fri, 20 Aug 2010 14:24:30 -0700 | Subject | Re: [2/3] mm: fix up some user-visible effects of the stack guard page |
| |
On Fri, Aug 20, 2010 at 2:17 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > > Appended is that much smaller patch.
Note that the "real" patch is actually even smaller than implied by this thing. The diffstat
include/linux/mm_types.h | 2 +- kernel/fork.c | 7 +++++-- mm/mmap.c | 37 +++++++++++++++++++++++++++++++++---- mm/nommu.c | 7 +++++-- 4 files changed, 44 insertions(+), 9 deletions(-)
implies that it adds a lot more than it removes, but of the 35 new lines it adds, about half of it - 16 lines - is just the vma list verification hack. So it really adds less than 20 lines of code. Hopefully those 20 lines would then buy themselves back with cleanups.
Still. A doubly-linked list is totally trivial, and I just bet I have a bug in there somewhere. But looking at your 2007 patch and mine side-by-side, I do think mine is still less scary.
Linus
| |