Messages in this thread | | | From | Linus Torvalds <> | Date | Fri, 20 Aug 2010 09:24:50 -0700 | Subject | Re: [2/3] mm: fix up some user-visible effects of the stack guard page |
| |
On Fri, Aug 20, 2010 at 9:07 AM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > > That said, it does strike me as rather odd to do VM ops on partial > stacks. What are you doing, exactly, to hit this?
The reason I ask is that the _sane_ thing to do - if we really care about this - is to change the 'vm_next' singly-linked list into using 'list.h'. It would clean up a fair amount of stuff, like removing the need for that disgusting 'find_vma_prev()' thing. There are actually several users of vma's that want to look at the previous vma, but because it's hard to get at, they do something non-intuitive or odd.
At the same time, we've had that vm_next pointer since pretty much day one, and I also get a strong feeling that it's not really worth the churn.
Linus
| |