lkml.org 
[lkml]   [2010]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 0/6] Remove owner field from sysfs attribute structure
    From
    Date
    On Fri, 2010-07-30 at 10:36 -0400, Greg KH wrote:
    > On Fri, Jul 30, 2010 at 08:28:10PM +1000, Benjamin Herrenschmidt wrote:
    > > On Fri, 2010-07-30 at 10:45 +0200, Tejun Heo wrote:
    > > > On 07/29/2010 07:09 AM, Guenter Roeck wrote:
    > > > > The following comment is found in include/linux/sysfs.h:
    > > > >
    > > > > /* FIXME
    > > > > * The *owner field is no longer used.
    > > > > * x86 tree has been cleaned up. The owner
    > > > > * attribute is still left for other arches.
    > > > > */
    > > > >
    > > > > As it turns out, the *owner field is (again?) initialized in several modules,
    > > > > suggesting that such initialization may be creeping back into the code.
    > > > >
    > > > > This patch set removes the above comment, the *owner field, and each instance
    > > > > in the code where it was found to be initialized.
    > > > >
    > > > > Compiled with x86 allmodconfig as well as with all alpha, arm, mips, powerpc,
    > > > > and sparc defconfig builds.
    > > >
    > > > Yeah, the change is way overdue. Maybe we should have just removed
    > > > them back then.
    > >
    > > I'm happy with the powerpc related patches as long as we all agree that
    > > needs to go. Do you need me to put some of this in powerpc.git or are
    > > you carrying them all to Linus ?
    >
    > I can carry them all in my driver-core tree if you don't object.
    >
    Any final verdict ?

    Not that it is my decision to make, but I think it would be better to
    have it all in one tree. Otherwise the timing for the last patch would
    get a bit complicated.

    Thanks,
    Guenter




    \
     
     \ /
      Last update: 2010-08-02 18:53    [W:2.365 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site