lkml.org 
[lkml]   [2010]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 6/7] vfs: only add " (deleted)" where necessary
    From
    On Mon, Aug 2, 2010 at 3:00 PM,  <Valdis.Kletnieks@vt.edu> wrote:
    > On Mon, 02 Aug 2010 13:20:01 +0200, Miklos Szeredi said:
    >
    >> Index: linux-2.6/fs/dcache.c
    >> ===================================================================
    >> --- linux-2.6.orig/fs/dcache.c        2010-07-06 18:08:16.000000000 +0200
    >> +++ linux-2.6/fs/dcache.c     2010-07-06 18:08:19.000000000 +0200
    >> @@ -1977,8 +1977,7 @@ global_root:
    >>   * @buffer: buffer to return value in
    >>   * @buflen: buffer length
    >>   *
    >> - * Convert a dentry into an ASCII path name. If the entry has been deleted
    >> - * the string " (deleted)" is appended. Note that this is ambiguous.
    >> + * Convert a dentry into an ASCII path name.
    >>   *
    >>   * Returns a pointer into the buffer or an error code if the
    >>   * path was too long.
    >
    > I'd prefer the comment about it being ambiguous remain.  I'm waiting to see how
    > long it takes for somebody to create a security hole by creating a file called
    > '/etc/some/thing/important (deleted)' and having some software Do The Wrong
    > Thing instead to /etc/some/thing/important.
    >

    In order to close this kind of hole why not creating a deleted
    directory on /proc and redirect symbolic link to this directory.
    And do the same for unreachable. If we use the good permission it will
    work from a backaward compatibily point of view

    bastien
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-08-02 15:25    [W:0.020 / U:181.296 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site