Messages in this thread Patch in this message | | | From | Amit Salecha <> | Date | Thu, 19 Aug 2010 04:12:51 -0500 | Subject | RE: [RFC Patch] netxen: remove firmware exports |
| |
> netxen_nic driver can store firmwares on flash, and get them porperly and > dynamically, so the firmwares may not appear in /lib/firmware/. However, netxen_nic > still exports these firmwares via modinfo, this makes our script which parses > modinfo output fail.
NX_UNIFIED_ROMIMAGE_NAME(phanfw.bin) is already submitted and we won't submit any other fw files.
> -MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME); > -MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME); > -MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);
It's not compulsory to submit firmware files which are exported (MODULE_FIRMWARE). I am leaving this upto David to decide about this patch.
-Amit
-----Original Message----- From: Amerigo Wang [mailto:amwang@redhat.com] Sent: Wednesday, August 18, 2010 3:25 PM To: linux-kernel@vger.kernel.org Cc: Dhananjay Phadke; Amit Salecha; Narender Kumar; netdev@vger.kernel.org; David S. Miller; Amerigo Wang Subject: [RFC Patch] netxen: remove firmware exports
netxen_nic driver can store firmwares on flash, and get them porperly and dynamically, so the firmwares may not appear in /lib/firmware/. However, netxen_nic still exports these firmwares via modinfo, this makes our script which parses modinfo output fail.
Probably netxen_nic has other way to export these firmwares, but not like other modules in a stardand way. I think we can just remove these exports, but I am not sure.
Signed-off-by: WANG Cong <amwang@redhat.com> Cc: Amit Kumar Salecha <amit.salecha@qlogic.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Dhananjay Phadke <dhananjay.phadke@qlogic.com> Cc: Narender Kumar <narender.kumar@qlogic.com>
--- diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c index fd86e18..e8443af 100644 --- a/drivers/net/netxen/netxen_nic_main.c +++ b/drivers/net/netxen/netxen_nic_main.c @@ -41,10 +41,6 @@ MODULE_DESCRIPTION("QLogic/NetXen (1/10) GbE Converged Ethernet Driver"); MODULE_LICENSE("GPL"); MODULE_VERSION(NETXEN_NIC_LINUX_VERSIONID); -MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME); -MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME); -MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME); -MODULE_FIRMWARE(NX_UNIFIED_ROMIMAGE_NAME); char netxen_nic_driver_name[] = "netxen_nic"; static char netxen_nic_driver_string[] = "QLogic/NetXen Network Driver v"
| |