lkml.org 
[lkml]   [2010]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 0/4] initramfs: remove sparse warnings
    From
    Date
    2010-08-19 (목), 16:38 +0200, Arnd Bergmann:
    > On Thursday 19 August 2010, Namhyung Kim wrote:
    > > This patchset removes most of sparse warnings in init/initramfs.c.
    > > Current implementation of initramfs relies on syscall service rountins heavily
    > > so it requires many of arguments to be __user address space pointers but, in
    > > most cases, were missing proper markups. This patchset tries to fix those at
    > > a minimum change.
    >
    > I'm skeptical about this, you are adding obviously incorrect annotations
    > to the code to make something work that was written without the awareness
    > for address spaces.
    >
    > A better way would be to call path_lookup or kern_path to look up the
    > path and pass that to a lower-level file I/O function.
    >
    > Arnd

    Thanks for the comment. Then I'll try to refactor/reimplement initramfs
    code based on your suggestion.

    --
    Regards,
    Namhyung Kim


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-08-19 19:01    [W:0.028 / U:0.208 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site