lkml.org 
[lkml]   [2010]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [MeeGo-Dev][PATCH] Topcliff: Update PCH_PHUB driver to 2.6.35
On Thu, Aug 19, 2010 at 03:27:23PM +0900, Masayuki Ohtake wrote:
> Hi Greg,
>
> Thank you for your comments.
> > > +#define MODULE_NAME "pch_phub"
> >
> > This isn't needed, right? The kernel provides this to you in the build
> > service automatically.
>
> I can't understand above enough.
> Is the above mean like below ?
>
> * Delete the following line.
> > > +#define MODULE_NAME "pch_phub"
>
> * Modify the following line(Use "pch_phub" directly)
> > > + ret = pci_request_regions(pdev, "pch_phub");

No, use the variable that the build system provides to you,
KBUILD_MODNAME

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-08-19 17:25    [W:0.073 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site