Messages in this thread | | | Date | Thu, 19 Aug 2010 08:26:16 +0530 | From | Ramkumar Ramachandra <> | Subject | Re: [PATCH] scripts/mkversion: Simplify script |
| |
Hi,
Sam Ravnborg writes: > On Thu, Aug 19, 2010 at 02:42:25AM +0530, Ramkumar Ramachandra wrote: > > Simplify the script and add a line to help editors recognize this as a > > shell script. > > This does not IMO simplify the script. > The original version is simple to follow for the usual C coder. > The new version is harder to follow. > > Adding the bangshee (#!/bin/sh) is fine.
Okay, we can drop the patch. I'll pick up some other janiorial tasks to get into the hang of writing patches.
-- Ram
| |