lkml.org 
[lkml]   [2010]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: lockdep false positive? -- firewire-core transaction timer vs. scsi-core host lock
    Stefan Richter wrote:
    > Clemens Ladisch wrote:
    > > spin_lock_irqsave(&card->lock, flags);
    > > list_for_each_entry(t, &card->transaction_list, link) {
    > > if (t == transaction) {
    > > + if (!del_timer(&t->split_timeout_timer))
    > > + goto timed_out;
    >
    > + if (!del_timer(&t->split_timeout_timer)) {
    > + spin_unlock_irqrestore(&card->lock, flags);
    > + goto timed_out;
    > + }

    > Shall I commit with the added spin_unlocks?

    I can obviously not be trusted to do this correctly; please go ahead.


    Regards,
    Clemens


    \
     
     \ /
      Last update: 2010-08-18 15:07    [W:0.021 / U:0.536 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site