lkml.org 
[lkml]   [2010]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [S+Q3 00/23] SLUB: The Unified slab allocator (V3)
Hello,

On 08/17/2010 06:56 AM, David Rientjes wrote:
> I'm adding Tejun Heo to the cc because of another thing that may be
> problematic: alloc_percpu() allocates GFP_KERNEL memory, so when we try to
> allocate kmem_cache_cpu for a DMA cache we may be returning memory from a
> node that doesn't include lowmem so there will be no affinity between the
> struct and the slab. I'm wondering if it would be better for the percpu
> allocator to be extended for kzalloc_node(), or vmalloc_node(), when
> allocating memory after the slab layer is up.

Hmmm... do you mean adding @gfp_mask to percpu allocation function?
I've been thinking about adding it for atomic allocations (Christoph,
do you still want it?). I've been sort of against it because I
primarily don't really like atomic allocations (it often just pushes
error handling complexities elsewhere where it becomes more complex)
and it would also require making vmalloc code do atomic allocations.

Most of percpu use cases seem pretty happy with GFP_KERNEL allocation,
so I'm still quite reluctant to change that. We can add a semi
internal interface w/ @gfp_mask but w/o GFP_ATOMIC support, which is a
bit ugly. How important would this be?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2010-08-17 10:03    [from the cache]
©2003-2011 Jasper Spaans