Messages in this thread | | | Date | Wed, 18 Aug 2010 03:26:03 +0200 | From | Michał Nazarewicz <> | Subject | Re: [PATCHv8 04/13] USB: gadget: mass_storage: moved strings handling code to composite |
| |
On Sat, 14 Aug 2010 02:23:42 +0200, Alan Stern <stern@rowland.harvard.edu> wrote:
> On Fri, 13 Aug 2010, David Brownell wrote: > >> --- On Fri, 8/13/10, Alan Stern <stern@rowland.harvard.edu> wrote: >> .> ... based on all >> > the preceding discussion, I now think the best >> > approach may be _never >> > to make up a fake serial number. Use the module >> > parameter, if any, and >> > otherwise issue a warning and don't have >> > a serial number string >> > descriptor (even though that violates the spec). >> >> >> Agreed, and that's what I had asked for. I didn't >> see code faking up a serial ... did I miss such? > > That code has been present in g_file_storage since the beginning. > There were some patches earlier which moved the code to a different > location. I guess you missed it. The current round of patches doesn't > touch that code.
Yep. I originally moved code from g_file_storage to g_mass_storage (and g_multi) but after David's objections the patches have been dropped so currently only g_file_storage has this code.
>> If so, let's see a new patch with no faking. > > An extra patch or two would be needed to remove the fake-serial > generation.
This should be a straightforward patch. If no one else does it I can post it but it may take up to a month for me to find the time to work on it.
-- Best regards, _ _ | Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o | Computer Science, Michał "mina86" Nazarewicz (o o) +----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |