lkml.org 
[lkml]   [2010]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH block#for-2.6.36-post] block: fix incorrect bio/request flag conversion in md
On Mon, Aug 16, 2010 at 04:21:25PM +0200, Tejun Heo wrote:
> Commit 74450be1 (block: unify flags for struct bio and struct request)
> incorrectly converted @do_sync in md raid1 and raid10 make_requst()
> functions.
>
> @do_sync is now supposed to carry the actual flag bit and directly
> OR'd into bio->bi_rw but is still a bool and thus carries either 0 or
> 1 instead of the actual flag bit. This makes REQ_SYNC ignored on
> writes and flips the direction of READ_SYNCs to WRITEs.
>
> Fix it by making @do_sync unsigned integers.

Yeah, you're the fourth person coming up with this independently. Now
all we need is to get one of the patches actually into Linus tree.



\
 
 \ /
  Last update: 2010-08-17 15:59    [W:0.032 / U:0.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site