lkml.org 
[lkml]   [2010]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 3/6] perf: Generalize some arch callchain code
On Mon, Aug 16, 2010 at 10:48:32PM +0200, Frederic Weisbecker wrote:

> - Most archs use one callchain buffer per cpu, except x86 that needs
> to deal with NMIs. Provide a default perf_callchain_buffer()
> implementation that x86 overrides.
>
> - Centralize all the kernel/user regs handling and invoke new arch
> handlers from there: perf_callchain_user() / perf_callchain_kernel()
> That avoid all the user_mode(), current->mm checks and so...
>
> - Invert some parameters in perf_callchain_*() helpers: entry to the
> left, regs to the right, following the traditional (src, dst).

I think you mean (dst, src), don't you?

Apart from that, the patch looks OK, so

Acked-by: Paul Mackerras <paulus@samba.org>

Paul.


\
 
 \ /
  Last update: 2010-08-17 06:55    [W:0.160 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site