lkml.org 
[lkml]   [2010]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] fix BUG using smp_processor_id() in touch_nmi_watchdog and touch_softlockup_watchdog
    On Mon, Aug 16, 2010 at 05:08:29PM +0300, Sergey Senozhatsky wrote:
    > void touch_softlockup_watchdog(void)
    > {
    > - __get_cpu_var(watchdog_touch_ts) = 0;
    > + int this_cpu = get_cpu();
    > + per_cpu(watchdog_touch_ts, this_cpu) = 0;
    > + put_cpu();
    > }



    If preemption is disabled and you deal with the current cpu,
    then please use __get_cpu_var, it makes the code more
    readable:


    void touch_softlockup_watchdog(void)
    {
    preempt_disable();
    __get_cpu_var(watchdog_touch_ts) = 0;
    preempt_enable();
    }


    Same below.

    Thanks.


    > EXPORT_SYMBOL(touch_softlockup_watchdog);
    >
    > @@ -142,7 +143,9 @@ void touch_all_softlockup_watchdogs(void)
    > #ifdef CONFIG_HARDLOCKUP_DETECTOR
    > void touch_nmi_watchdog(void)
    > {
    > - __get_cpu_var(watchdog_nmi_touch) = true;
    > + int this_cpu = get_cpu();
    > + per_cpu(watchdog_nmi_touch, this_cpu) = true;
    > + put_cpu();
    > touch_softlockup_watchdog();
    > }
    > EXPORT_SYMBOL(touch_nmi_watchdog);
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/



    \
     
     \ /
      Last update: 2010-08-17 05:03    [W:0.023 / U:58.952 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site