lkml.org 
[lkml]   [2010]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC PATCH 1/6] perf: Drop unappropriate tests on arch callchains
    Date
    Drop the TASK_RUNNING test on user tasks for callchains as
    this check doesn't seem to make any sense.

    Also remove the tests for !current that is not supposed to
    happen and current->pid as this should be handled at the
    generic level, with exclude_idle attribute.

    Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: David Miller <davem@davemloft.net>
    Cc: Paul Mundt <lethal@linux-sh.org>
    Cc: Will Deacon <will.deacon@arm.com>
    Cc: Borislav Petkov <bp@amd64.org>
    ---
    arch/arm/kernel/perf_event.c | 6 ------
    arch/sh/kernel/perf_callchain.c | 3 ---
    arch/x86/kernel/cpu/perf_event.c | 3 ---
    3 files changed, 0 insertions(+), 12 deletions(-)

    diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c
    index 417c392..fdcb0be 100644
    --- a/arch/arm/kernel/perf_event.c
    +++ b/arch/arm/kernel/perf_event.c
    @@ -3107,12 +3107,6 @@ perf_do_callchain(struct pt_regs *regs,

    is_user = user_mode(regs);

    - if (!current || !current->pid)
    - return;
    -
    - if (is_user && current->state != TASK_RUNNING)
    - return;
    -
    if (!is_user)
    perf_callchain_kernel(regs, entry);

    diff --git a/arch/sh/kernel/perf_callchain.c b/arch/sh/kernel/perf_callchain.c
    index a9dd3ab..1d6dbce 100644
    --- a/arch/sh/kernel/perf_callchain.c
    +++ b/arch/sh/kernel/perf_callchain.c
    @@ -68,9 +68,6 @@ perf_do_callchain(struct pt_regs *regs, struct perf_callchain_entry *entry)

    is_user = user_mode(regs);

    - if (is_user && current->state != TASK_RUNNING)
    - return;
    -
    /*
    * Only the kernel side is implemented for now.
    */
    diff --git a/arch/x86/kernel/cpu/perf_event.c b/arch/x86/kernel/cpu/perf_event.c
    index f2da20f..4a4d191 100644
    --- a/arch/x86/kernel/cpu/perf_event.c
    +++ b/arch/x86/kernel/cpu/perf_event.c
    @@ -1703,9 +1703,6 @@ perf_do_callchain(struct pt_regs *regs, struct perf_callchain_entry *entry)

    is_user = user_mode(regs);

    - if (is_user && current->state != TASK_RUNNING)
    - return;
    -
    if (!is_user)
    perf_callchain_kernel(regs, entry);

    --
    1.6.2.3


    \
     
     \ /
      Last update: 2010-08-16 22:51    [W:3.851 / U:1.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site