Messages in this thread | | | From | Lei Wen <> | Date | Mon, 16 Aug 2010 07:03:11 -0700 | Subject | RE: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset for samsung2GbX8 |
| |
Eric, The first patch is a bit of fundamental. I'm afraid that modify it would bring changes to all latter patches in this series...
So I think I would repost another round of updating patch series and hope that would be merged. How do you think about this?
Thanks, Lei
-----Original Message----- From: Eric Miao [mailto:eric.y.miao@gmail.com] Sent: 2010年8月16日 21:55 To: David Woodhouse Cc: Haojian Zhuang; Lei Wen; Axel Lin; linux-kernel; linux-mtd@lists.infradead.org Subject: Re: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset for samsung2GbX8
On Mon, Aug 16, 2010 at 9:05 PM, David Woodhouse <dwmw2@infradead.org> wrote: > On Mon, 2010-08-16 at 20:55 +0800, Eric Miao wrote: >> On Mon, Aug 16, 2010 at 8:49 PM, Haojian Zhuang <hzhuang1@marvell.com> wrote: >> > http://lists.infradead.org/pipermail/linux-mtd/2010-July/subject.html >> > >> > They're re-posted in July. Please search the subjects in that page. They're totally 29 patches. >> > >> > By the way, David, what's the result of review on these patches? We already posted for several times. >> > >> >> I've actually reviewed some of the patches and gave my Ack. For those >> patches, I think they can be merged early. >> >> And overall, they look good. Yet 29 patch in a whole is still a bit too >> much, would be good to see them logically be separated into several >> patch series. > > You had some criticism of patch #1 in the sequence, and some questions. >
So they need to be addressed. Lei, could you please come up with an updated patch?
> I didn't look much harder than that, iirc... although looking back now > it seems that the rest of your responses to the sequence were largely > positive. > > Are you happy with the first patch, and if so shall I go ahead and > import the whole sequence with your Acked-By:? >
I'm generally OK, but still think it would be good to have another around of review before they can be merged.
| |