lkml.org 
[lkml]   [2010]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/9] RapidIO: Add default handler for error_stopped state
Alexandre Bounine wrote:
> +
> + if (err_status & RIO_PORT_N_ERR_STS_PW_OUT_ES) {
> + pr_debug("RIO_EM: servicing Output Error-Stopped state\n");
> + /*
> + * Send a Link-Request/Input-Status control symbol
> + */
> +
> + /* Read from link maintenance response register
> + * to clear valid bit */
> + rio_mport_read_config_32(mport, destid, hopcount,
> + rdev->phys_efptr + RIO_PORT_N_MNT_RSP_CSR(pnum),
> + &regval);
> + udelay(50);

Perhaps this whole part of operating the MNT_RSP registers (sending
link-request symbol is the only useful action IIRC?) can be put in a
separate function for readability.

Micha


\
 
 \ /
  Last update: 2010-08-16 14:23    [W:1.618 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site