lkml.org 
[lkml]   [2010]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 56/68] serial: MMIO32 support for 8250_early.c
On Thu, Aug 12, 2010 at 11:43:15AM -0700, Tony Luck wrote:
> On Tue, Aug 10, 2010 at 2:59 PM, Greg Kroah-Hartman <gregkh@suse.de> wrote:
> > +       if (mmio || mmio32)
> > +               printk(KERN_INFO
> > +                      "Early serial console at MMIO%s 0x%llu (options '%s')\n",
> > +                       mmio32 ? "32" : "",
> > +                       (unsigned long long)port->mapbase,
> > +                       device->options);
> > +       else
> > +               printk(KERN_INFO
> > +                     "Early serial console at I/O port 0x%lu (options '%s')\n",
> > +                       port->iobase,
> > +                       device->options);
> > +
>
> This change looks to be responsible for some confusing dmesg output. Here's some
> diff between v2.6.35 and current Linus tree:
>
>
> < Early serial console at I/O port 0x3f8 (options '115200')
> ---
> > Early serial console at I/O port 0x1016 (options '115200')
>
> Note that my serial port didn't move to a different address. Hex(3f8)
> == Decimal(1016)
>
> I think those two printk formats should be using 'x' format rather than 'u' :-)

Very good point, someone want to send me a patch?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-08-12 21:11    [W:0.111 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site