lkml.org 
[lkml]   [2010]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to 2.6.35
> -----Original Message-----
> From: Greg KH [mailto:gregkh@suse.de]
> Sent: Wednesday, August 11, 2010 11:15 PM
> To: Masayuki Ohtake
> Cc: meego-dev@meego.com; LKML; Wang, Qi; Wang, Yong Y; Khor, Andrew
> Chih Howe; arjan@linux.intel.com
> Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to
> 2.6.35
>
> On Wed, Aug 11, 2010 at 04:29:25PM +0900, Masayuki Ohtake wrote:
> > Hi Greg,
> >
> > > Do they all have to be ioctls? What exactly are they doing?
> > I think using ioctl is common for this patch.
>
> "Common" is not ok, right?
>
> > Do you think that using ioctl is NOT appropriate for this patch?
>
> Yes.
>
> > Let me know your intension in more detail.
>
> Please express yours. Why do you feel you need these to be ioctls?
> What exactly are they doing? Where is the documentation for them all?
>
> > > And are they 32/64bit safe?
> > Only 32bit support.
>
> That's an obvious problem that needs to be resolved, right?
The Tunnelcreak processor (A kind of Atom-based processor) only supports 32b, so PCH drivers only support 32b.
They can make it 32/64 compatible, but it's difficult to test them, because there're no 64b Atom-based platform have those PCH devices.

Best Regards,
QI.
>
> thanks,
>
> greg k-h
\
 
 \ /
  Last update: 2010-08-12 03:17    [W:0.089 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site