Messages in this thread | | | From | Dmitry Torokhov <> | Date | Wed, 11 Aug 2010 00:35:51 -0700 | Subject | Re: [PATCH 1/2] param: allow omitting set() methods for truly read-only params |
| |
On Aug 10, 2010, at 6:39 PM, "Rusty Russell" <rusty@rustcorp.com.au> wrote:
> On Wed, 11 Aug 2010 04:28:44 am Dmitry Torokhov wrote: >> Certain "parameters", such as acpica version and upcoming VMware >> Balloon >> version, are need to be purely read-only. They are exported as >> parameters so that they are visible in sysfs even in cases when the >> module is built directly into the kernel, but their values should be >> immutable. Specifying S_IRUGO takes care of sysfs interface, but it >> has no effect on kernel command line or modprobe configuration >> files and >> so these "parameters" attempt to omit set() method. Unfortunately >> kernel expects set() to be always present and crashes if it is not >> there, so let's add appropriate check. >> >> Signed-off-by: Dmitry Torokhov <dtor@vmware.com> > > That almost makes sense, but not quite. > > Your followup patch uses this for version, but the version is already > in /sys/module/vmware_balloon/version as is standard with modules, no? >
That version attribute is not present if the driver is built-in, only parameters are visible in both cases.
-- Dmitry
| |