lkml.org 
[lkml]   [2010]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] Low-level initialization for hsmmc controller on LogicPD's OMAP3 SOM and TORPEDO dev kits
Hi,

On Wed, Aug 11, 2010 at 06:31:35PM +0200, ext Jacob Tanenbaum wrote:
>+#define OMAP3_TORPEDO_MMC_GPIO_WP (-EINVAL)

this one isn't used anywhere, why adding it ?

>+static struct regulator_init_data omap3logic_vmmc1 = {
>+ .constraints = {
>+ .name = "VMMC1",
>+ .min_uV = 1850000,
>+ .max_uV = 3150000,
>+ .valid_modes_mask = REGULATOR_MODE_NORMAL
>+ | REGULATOR_MODE_STANDBY,
>+ .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE
>+ | REGULATOR_CHANGE_MODE
>+ | REGULATOR_CHANGE_STATUS,
>+ },
>+ .num_consumer_supplies = 1,
>+ .consumer_supplies = &omap3logic_vmmc1_supply,
>+};
>+
>+
>+

one blank line only.

>+ } else {
>+ printk(KERN_ERR "%s(): unknown machine type\n", __func__);
>+ return;

indentation is wrong.

>+ omap2_hsmmc_init(board_mmc_info);
>+ /* link regulators to MMC adapters */
>+ omap3logic_vmmc1_supply.dev = board_mmc_info[0].dev;
>+}
>+
>+
>+

one blank line only.

> /* Ensure SDRC pins are mux'd for self-refresh */
>-/* omap_cfg_reg(H16_34XX_SDRC_CKE0);
>- omap_cfg_reg(H17_34XX_SDRC_CKE1);
>- omap_cfg_reg(SDRC_CKE0);
>- omap_cfg_reg(SDRC_CKE1); */

this shouldn't even be here in the first place. :-)

--
balbi

DefectiveByDesign.org


\
 
 \ /
  Last update: 2010-08-11 19:27    [W:0.134 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site