lkml.org 
[lkml]   [2010]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] serport: place serport serio device correctly in the device tree
On Mon, Aug 09, 2010 at 06:22:50PM +0400, Dmitry Eremin-Solenikov wrote:
> Make serport serio device to be a child of corresponding tty device
> instead of just hanging at /sys/devices/serioX.
>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Looks good to me.

Acked-by: Dmitry Torokhov <dtor@mail.ru>

> ---
> drivers/input/serio/serport.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/serio/serport.c b/drivers/input/serio/serport.c
> index 6d34511..6e362de 100644
> --- a/drivers/input/serio/serport.c
> +++ b/drivers/input/serio/serport.c
> @@ -165,6 +165,7 @@ static ssize_t serport_ldisc_read(struct tty_struct * tty, struct file * file, u
> serio->open = serport_serio_open;
> serio->close = serport_serio_close;
> serio->port_data = serport;
> + serio->dev.parent = tty->dev;
>
> serio_register_port(serport->serio);
> printk(KERN_INFO "serio: Serial port %s\n", tty_name(tty, name));
> --
> 1.7.1
>

--
Dmitry


\
 
 \ /
  Last update: 2010-08-11 05:31    [W:0.055 / U:3.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site