Messages in this thread | | | Date | Tue, 10 Aug 2010 07:17:19 -0500 | From | Nathan Fontenot <> | Subject | Re: [PATCH 8/8] v5 Update memory-hotplug documentation |
| |
On 08/09/2010 03:44 PM, Nishanth Aravamudan wrote: > On Monday, August 09, 2010 11:43:46 am Nathan Fontenot wrote: >> Update the memory hotplug documentation to reflect the new behaviors of >> memory blocks reflected in sysfs. > > <snip> > >> Index: linux-2.6/Documentation/memory-hotplug.txt >> =================================================================== >> --- linux-2.6.orig/Documentation/memory-hotplug.txt 2010-08-09 07:36:48.000000000 -0500 >> +++ linux-2.6/Documentation/memory-hotplug.txt 2010-08-09 07:59:54.000000000 -0500 > > <snip> > >> -/sys/devices/system/memory/memoryXXX/phys_index >> +/sys/devices/system/memory/memoryXXX/start_phys_index >> +/sys/devices/system/memory/memoryXXX/end_phys_index >> /sys/devices/system/memory/memoryXXX/phys_device >> /sys/devices/system/memory/memoryXXX/state >> /sys/devices/system/memory/memoryXXX/removable >> >> -'phys_index' : read-only and contains section id, same as XXX. > > <snip> > >> +'phys_index' : read-only and contains section id of the first section > > Shouldn't this be "start_phys_index"?
Hmmm... looks like I missed something in the documentation.
The property should be 'phys_index'. I thought about changing it to 'start_phys_index' but that was rejected. The listing of the files above is wrong in this patch, it should be
+/sys/devices/system/memory/memoryXXX/phys_index +/sys/devices/system/memory/memoryXXX/end_phys_index
Thanks,
Nathan
| |