lkml.org 
[lkml]   [2010]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix)
    On Wed, Jul 21, 2010 at 06:21:08PM -0500, Scott Wood wrote:
    [...]
    > > > > + { .compatible = "fsl,p4080-l2-cache-controller", },
    > > >
    > > > L2 on the p4080 is quite different from those other chips. It's part
    > > > of the core, controlled by SPRs.
    > >
    > > erm, was that an ack or a nack?
    >
    > NACK, p4080 doesn't belong in this table, at least not its L2.
    >
    > L3 on p4080 is similar to L2 on these other chips, though, and it
    > wouldn't take much to get this driver working on it -- but the match
    > table entry should wait until the differences are accommodated.

    Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
    ---

    Scott, thanks for catching this!

    Andrew, please merge this patch into
    edac-mpc85xx-add-support-for-new-mpcxxx-pxxxx-edac-controllers.patch

    Thanks!

    drivers/edac/mpc85xx_edac.c | 1 -
    1 files changed, 0 insertions(+), 1 deletions(-)

    diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
    index cfa86f7..b178cfa 100644
    --- a/drivers/edac/mpc85xx_edac.c
    +++ b/drivers/edac/mpc85xx_edac.c
    @@ -652,7 +652,6 @@ static struct of_device_id mpc85xx_l2_err_of_match[] = {
    { .compatible = "fsl,p1020-l2-cache-controller", },
    { .compatible = "fsl,p1021-l2-cache-controller", },
    { .compatible = "fsl,p2020-l2-cache-controller", },
    - { .compatible = "fsl,p4080-l2-cache-controller", },
    {},
    };
    MODULE_DEVICE_TABLE(of, mpc85xx_l2_err_of_match);
    --
    1.7.0.5


    \
     
     \ /
      Last update: 2010-08-01 12:57    [W:0.023 / U:64.336 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site