Messages in this thread | | | Subject | Re: [PATCH][GIT PULL][for 2.6.35] tracing: Add alignment to syscall metadata declarations | From | Steven Rostedt <> | Date | Fri, 09 Jul 2010 17:05:50 -0400 |
| |
On Fri, 2010-07-09 at 22:53 +0200, Sam Ravnborg wrote:
> But in this case we have no control of the value of "." (current address) > when we have processed (_ftrace_events) so it may even be at a 2 byte boundary. > The linker will add padding as needed to satisfy the alignmnet of > __syscalls_metadata - but that padding will be inbetween "." and the first > member in __syscalls_metadata.
Fine, but this is a separate issue. I doubt the "ALIGN(8);" would have helped us anyway. Remember what the issue we had:
ffffffff8173c438 <__start_syscalls_metadata>: ...
ffffffff8173c440 <__syscall_meta__mmap>:
__start_syscalls_metadata was already aligned to 8, but for some strange reason, gcc decided to align the first member to 16.
-- Steve
| |