lkml.org 
[lkml]   [2010]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]ipmi:ipmi_si_intf.c Fix warning: variable 'addr_space' set but not used
Looks good to me:

Acked-by: Corey Minyard <cminyard@mvista.com>

On 07/08/2010 02:09 PM, Justin P. Mattock wrote:
> The below patch fixes a warning message generated by GCC, and also
> updates a web address pointing to a pdf containging information.
> CC [M] drivers/char/ipmi/ipmi_si_intf.o
> drivers/char/ipmi/ipmi_si_intf.c: In function 'try_init_spmi':
> drivers/char/ipmi/ipmi_si_intf.c:2016:8: warning: variable 'addr_space' set but not used
>
> Signed-off-by: Sergey V.<sftp.mtuci@gmail.com>
> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>
> ---
> drivers/char/ipmi/ipmi_si_intf.c | 10 ++--------
> 1 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 094bdc3..7e40d02 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -1965,8 +1965,8 @@ static int acpi_gpe_irq_setup(struct smi_info *info)
>
> /*
> * Defined at
> - * http://h21007.www2.hp.com/dspp/files/unprotected/devresource/
> - * Docs/TechPapers/IA64/hpspmi.pdf
> + * http://h21007.www2.hp.com/portal/download/files
> + * /unprot/hpspmi.pdf
> */
> struct SPMITable {
> s8 Signature[4];
> @@ -2013,18 +2013,12 @@ struct SPMITable {
> static __devinit int try_init_spmi(struct SPMITable *spmi)
> {
> struct smi_info *info;
> - u8 addr_space;
>
> if (spmi->IPMIlegacy != 1) {
> printk(KERN_INFO PFX "Bad SPMI legacy %d\n", spmi->IPMIlegacy);
> return -ENODEV;
> }
>
> - if (spmi->addr.space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY)
> - addr_space = IPMI_MEM_ADDR_SPACE;
> - else
> - addr_space = IPMI_IO_ADDR_SPACE;
> -
> info = kzalloc(sizeof(*info), GFP_KERNEL);
> if (!info) {
> printk(KERN_ERR PFX "Could not allocate SI data (3)\n");
>



\
 
 \ /
  Last update: 2010-07-08 22:09    [W:0.032 / U:0.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site