lkml.org 
[lkml]   [2010]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 11/12] Let host know whether the guest can handle async PF in non-userspace context.
On Thu, Jul 08, 2010 at 12:28:18AM -0400, Rik van Riel wrote:
> On 07/06/2010 12:24 PM, Gleb Natapov wrote:
> >If guest can detect that it runs in non-preemptable context it can
> >handle async PFs at any time, so let host know that it can send async
> >PF even if guest cpu is not in userspace.
>
> The code looks correct. One question though - is there a
> reason to implement the userspace-only async PF path at
> all, since the handling of async PF in non-userspace context
> is introduced simultaneously?
>
Guest userspace-only async PF handling is added in patch 4 and
non-userspace is added in patch 10. It is done for easy reviewing.
If I implement everything in one patch it will be harder to see why
things are done the way they are IMHO.

--
Gleb.


\
 
 \ /
  Last update: 2010-07-08 15:39    [from the cache]
©2003-2011 Jasper Spaans