Messages in this thread | | | Subject | Re: [PATCH 13/18] ima: use generic_file_llseek for securityfs | From | Mimi Zohar <> | Date | Thu, 08 Jul 2010 09:18:22 -0400 |
| |
On Thu, 2010-07-08 at 15:00 +0200, Arnd Bergmann wrote: > On Thursday 08 July 2010, Mimi Zohar wrote: > > On Wed, 2010-07-07 at 23:40 +0200, Arnd Bergmann wrote: > > > The default for llseek will change to no_llseek, > > > so securityfs users need to add explicit .llseek > > > assignments. Since we're dealing with regular > > > files from a VFS perspective, use generic_file_llseek. > > > > As both the 'violations' and 'runtime_measurement_counts' are single > > values and 'policy' doesn't support read, this patch doesn't hurt, but > > adding .llseek is probably unnecessary. > > Ok, thanks for the confirmation. > > Are you applying the patch in your tree, or should I keep it in my > series?
I'll leave that up to James.
> Note that while it may not be necessary to add these specific .llseek > operations, the reason I'm doing it is because I want to provably > have a .llseek operation in every file_operation in the kernel before > the default gets changed. > > Arnd
Thanks for the clarification.
Mimi
| |