lkml.org 
[lkml]   [2010]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/9] remove q->prepare_flush_fn hook
On Thu, Jul 08, 2010 at 08:54:59AM +0900, FUJITA Tomonori wrote:
> On Wed, 7 Jul 2010 15:52:09 -0400
> Christoph Hellwig <hch@infradead.org> wrote:
>
> > One weird thing after this set is that the flush commands don't have any
> > cmd_type. I think it should be set to REQ_TYPE_FS, even if we might be
> > resetting it inside the driver for now.
>
> I think even before this patchset, the block layer doesn't set
> rq->cmd_type on flush requests (scsi and Ode sets it in
> prepare_flush_fn).

Indeed it didn't. But before that it matters less because
prepare_flush_fn set it before the command entered prep_fn.



\
 
 \ /
  Last update: 2010-07-08 02:01    [W:0.064 / U:2.876 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site