Messages in this thread | | | Date | Wed, 7 Jul 2010 13:04:18 -0700 | From | Joel Becker <> | Subject | Re: [PATCH 1/3] ocfs2: When zero extending, do it by page. |
| |
On Wed, Jul 07, 2010 at 11:19:27PM +0800, Tao Ma wrote: > >+static handle_t *ocfs2_zero_start_ordered_transaction(struct inode *inode) > >+{ > >+ struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); > >+ handle_t *handle = NULL; > >+ int ret = 0; > >+ > >+ if (ocfs2_should_order_data(inode)) > This should be if (!ocfs2_should_order_data(inode)) I guess? ;)
Of course it should. Fixed ;-)
Joel
--
"Too much walking shoes worn thin. Too much trippin' and my soul's worn thin. Time to catch a ride it leaves today Her name is what it means. Too much walking shoes worn thin."
Joel Becker Consulting Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127
| |