[lkml]   [2010]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] x86: KVM, fix lock imbalance

* Avi Kivity <> wrote:

> On 07/07/2010 04:07 PM, Jiri Slaby wrote:
> >
> >>A cleanliness comment: why is that tear-down/dealloc sequence open-coded? It
> >>should be at the end of the function, with goto labels, like we do it in
> >>similar cases.
> >Because the lock is around a block only. I usually don't create a goto
> >fail-paths in these cases. Do you want one?
> In any case, the patch is a minimal fix, so I'll apply it. Any clean ups
> can go on top.

The reason the pattern caught my attention is that it is one of the typical
cases where goto labels help prevent similar bugs. I.e. had it been clean to
begin with the bug might not have happened.



 \ /
  Last update: 2010-07-07 16:13    [W:0.046 / U:8.288 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site