lkml.org 
[lkml]   [2010]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: BUG in drivers/dma/ioat/dma_v2.c:314
From
On Tue, Jul 6, 2010 at 5:51 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> No, it should be PCI_DEVICE_ID_INTEL_IOAT_SNB (0x402f) for the dma
> engine at 00:0f.0 .  PCI_DEVICE_ID_INTEL_ESB2_0 is the LPC controller at
> 00:1f.0,
>
>> That seems to be the reason preventing the warning to be print out. I am not
>> sure the warning should be always print out. Just curious why it did
>> not trigger.
>
> It should always trigger, and I have verified as much with the attached
> replacement patch (by forcing the error on a working system), but we run
> into a new problem.  dma_pool_alloc() assumes that any dma_mapping error
> is transient.  Do we need a new type of dma_mapping_error() that
> indicates permanent failure versus ENOMEM?  The driver can handle the
> allocation failure, but it never gets the chance.

Should I test your V2 patch instead?

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-07-07 02:53    [W:0.100 / U:1.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site