Messages in this thread | | | Date | Tue, 6 Jul 2010 11:57:03 -0700 | From | Joel Becker <> | Subject | Re: [PATCH 1/2] ocfs2: Zero the tail cluster when extending past i_size v2 |
| |
On Mon, Jul 05, 2010 at 11:51:44AM +0800, Tao Ma wrote: > On 07/04/2010 05:32 AM, Joel Becker wrote: > From here to the call of CoW is a bit hard to understand. In 'if', > num_clusters is set for CoW and in 'else', blocks_to_zero is set. So > it isn't easy for the reader to tell why these 2 clauses are setting > different values. So how about my code below? It looks more > straightforward I think.
I took your cleanup mostly.
Joel
--
"The cynics are right nine times out of ten." - H. L. Mencken
Joel Becker Consulting Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127
| |