lkml.org 
[lkml]   [2010]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch v2.3 3/4] IPVS: make FTP work with full NAT support
    Simon Horman wrote:
    > @@ -219,19 +358,23 @@ static int ip_vs_ftp_out(struct ip_vs_ap
    >
    > buf_len = strlen(buf);
    >
    > + ct = nf_ct_get(skb, &ctinfo);
    > + ret = nf_nat_mangle_tcp_packet(skb,
    > + ct,
    > + ctinfo,
    > + start-data,
    > + end-start,
    > + buf,
    > + buf_len);
    > +
    > + if (ct && ct != &nf_conntrack_untracked)
    >
    This does not make sense, you're already using the conntrack above
    in the call to nf_nat_mangle_tcp_packet(), so the check should
    probably happen before that. You also should be checking the
    return value of nf_nat_mangle_tcp_packet() before setting up the
    expectation.

    > + ip_vs_expect_related(skb, ct, n_cp,
    > + IPPROTO_TCP, NULL, 0);



    \
     
     \ /
      Last update: 2010-07-06 13:45    [W:0.019 / U:30.420 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site