lkml.org 
[lkml]   [2010]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 7/7] hugetlb, HWPOISON: soft offlining for hugepage
    > +void isolate_hwpoisoned_huge_page(struct page *hpage)
    > +{
    > + lock_page(hpage);
    > + __isolate_hwpoisoned_huge_page(hpage);
    > + unlock_page(hpage);
    > +}

    This assumes all other users (even outside this file)
    who lock always do so on the head page too. Needs some double-checking?

    > } else {
    > pr_debug("soft offline: %#lx: isolation failed: %d, page count %d, type %lx\n",
    > pfn, ret, page_count(page), page->flags);
    > @@ -1351,8 +1380,8 @@ int soft_offline_page(struct page *page, int flags)
    > return ret;
    >
    > done:
    > - atomic_long_add(1, &mce_bad_pages);
    > - SetPageHWPoison(page);
    > + atomic_long_add(1 << compound_order(hpage), &mce_bad_pages);

    Probably should add a separate counter too?

    -Andi
    --
    ak@linux.intel.com -- Speaking for myself only.


    \
     
     \ /
      Last update: 2010-07-05 12:31    [W:4.220 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site