Messages in this thread | | | Date | Mon, 05 Jul 2010 10:03:12 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH 0/9] remove q->prepare_flush_fn hook |
| |
On 2010-07-05 10:01, FUJITA Tomonori wrote: > On Mon, 05 Jul 2010 08:55:36 +0200 > Jens Axboe <axboe@kernel.dk> wrote: > >> On 2010-07-03 10:45, FUJITA Tomonori wrote: >>> This removes q->prepare_flush_fn. Except for ide and scsi, all the >>> users just mark flush requests. They can use REQ_FLUSH flag >>> instead. >>> >>> SCSI and ide can use q->prep_rq_fn to build flush requests. >>> >>> This can be applied to the block's for-2.6.36. >> >> Thanks, applied. > > Thanks, > > looks like you applied the patches in a wrong order (breaks bisect). > > At least, the first two patches need to be applied in order before the > rest: > > [PATCH 1/9] block: introduce REQ_FLUSH flag > [PATCH 2/9] block: permit PREFLUSH and POSTFLUSH without prepare_flush_fn
Funky, my patch script must have shuffled them, that was definitely not on purpose. Guess I'll have to rebase to fix that up...
-- Jens Axboe
| |